Fix failure for None task summaries #23932
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
alternative-fix-to-grid-summary-error
branch
2 times, most recently
from
eb97694 to
93eb937
Compare
Alternative fix to apache#23908 - with added typing.
potiuk
force-pushed
the
alternative-fix-to-grid-summary-error
branch
from
93eb937 to
7428be0
Compare
potiuk
commented
May 26, 2022
| @@ -101,6 +101,7 @@ class AbstractOperator(LoggingMixin, DAGNode): | |||
|
|
|||
| owner: str | |||
| task_id: str | |||
| is_mapped: ClassVar[bool] | |||
There was a problem hiding this comment.
@uranusjr -> maybe there is another way, but I believe the lack of "is_mapped" in AbstractOperator was a bit wrong (and it would prevent adding the proper typing in task_group_to_grid ad AbstractOperator missed is_mapped field).
|
Better/faster fix in #23947 . Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative fix to #23908 - with added typing.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.