Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'reschedule' to the serialized fields for the BaseSensorOperator #23674

Merged
merged 2 commits into from
May 17, 2022
Merged

Add 'reschedule' to the serialized fields for the BaseSensorOperator #23674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32d3429
add 'reschedule' to the serialized fields...
davidcaron May 12, 2022
eee4b5c
add 'reschedule' assert in test_serialize_sensor
davidcaron May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions airflow/sensors/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,10 @@ def reschedule(self):
"""Define mode rescheduled sensors."""
return self.mode == 'reschedule'

@classmethod
def get_serialized_fields(cls):
return super().get_serialized_fields() | {"reschedule"}


def poke_mode_only(cls):
"""
Expand Down
1 change: 1 addition & 0 deletions tests/serialization/test_dag_serialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1462,6 +1462,7 @@ def poke(self, context: Context):
assert "deps" in blob

serialized_op = SerializedBaseOperator.deserialize_operator(blob)
assert serialized_op.reschedule == (mode == "reschedule")
assert op.deps == serialized_op.deps

@pytest.mark.parametrize(
Expand Down
7 changes: 6 additions & 1 deletion tests/ti_deps/deps/test_ready_to_reschedule_dep.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
class TestNotInReschedulePeriodDep(unittest.TestCase):
def _get_task_instance(self, state):
dag = DAG('test_dag')
task = Mock(dag=dag)
task = Mock(dag=dag, reschedule=True)
ti = TaskInstance(task=task, state=state, run_id=None)
return ti

Expand All @@ -52,6 +52,11 @@ def test_should_pass_if_ignore_in_reschedule_period_is_set(self):
dep_context = DepContext(ignore_in_reschedule_period=True)
assert ReadyToRescheduleDep().is_met(ti=ti, dep_context=dep_context)

def test_should_pass_if_not_reschedule_mode(self):
ti = self._get_task_instance(State.UP_FOR_RESCHEDULE)
del ti.task.reschedule
assert ReadyToRescheduleDep().is_met(ti=ti)

def test_should_pass_if_not_in_none_state(self):
ti = self._get_task_instance(State.UP_FOR_RETRY)
assert ReadyToRescheduleDep().is_met(ti=ti)
Expand Down