Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpsgenieDeleteAlertOperator #23405

Merged
merged 4 commits into from
May 6, 2022
Merged

Add OpsgenieDeleteAlertOperator #23405

merged 4 commits into from
May 6, 2022

Conversation

eladkal
Copy link
Contributor

@eladkal eladkal commented May 2, 2022

Adding operator for delete_alert in Opsgenie SDK.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@eladkal eladkal requested a review from josh-fell May 4, 2022 04:58
@eladkal
Copy link
Contributor Author

eladkal commented May 5, 2022

ping @josh-fell :)

Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit on Optional default value, but otherwise LGTM.

airflow/providers/opsgenie/hooks/opsgenie.py Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented May 6, 2022

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers kind:documentation okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants