fix cli airflow show dags for mapped operator #23339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
approved these changes
Apr 29, 2022
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
jedcunningham
approved these changes
Apr 30, 2022
ephraimbuddy
pushed a commit
that referenced
this pull request
May 8, 2022
(cherry picked from commit 59e9310)
ephraimbuddy
pushed a commit
that referenced
this pull request
May 21, 2022
(cherry picked from commit 59e9310)
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For mapped operators,
airflow show dags <dag_id>is broken (see #23315 )Task expansion creates a MappedOperator, which ultimately inherits from AbstractOperator and not BaseOperator.
airflow dags showultimately calls dot_renderer.py to draw the DAG, and it checks that each node is either aTaskGroupor aBaseOperator, thus the error. Adding a check to see if the node is anAbstractOperatorfixes this.closes: #23315