Add is_mapped field to Task response. #23319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
norm
reviewed
Apr 28, 2022
| @@ -58,6 +58,7 @@ class TaskSchema(Schema): | |||
| sub_dag = fields.Nested(DAGSchema, dump_only=True) | |||
| downstream_task_ids = fields.List(fields.String(), dump_only=True) | |||
| params = fields.Method('get_params', dump_only=True) | |||
| is_mapped = fields.Boolean(dump_only=True) | |||
There was a problem hiding this comment.
Adding a field to the schema also requires adding it to the API definition in airflow/api_connexion/openapi/v1.yaml (line 2,938 onwards), so that it shows up in the docs.
There was a problem hiding this comment.
Thanks, I though it was automatically generated. Added now.
norm
reviewed
Apr 28, 2022
bbovenzi
approved these changes
Apr 28, 2022
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
ephraimbuddy
approved these changes
Apr 28, 2022
norm
approved these changes
Apr 28, 2022
ephraimbuddy
added
type:bug-fix
ephraimbuddy
pushed a commit
that referenced
this pull request
May 27, 2022
* Add is_mapped field to Task response. * Add is_mapped to schema file and add test for GetTasks. (cherry picked from commit f3d80c2)
This was referenced May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #23284
related: #23284