Fix update user auth stats #23314
Merged
Fix update user auth stats #23314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blag
force-pushed
the
fix-update-user-auth-stats
branch
from
75c7de6 to
baa8982
Compare
blag
force-pushed
the
fix-update-user-auth-stats
branch
from
baa8982 to
8b7db12
Compare
jedcunningham
approved these changes
Apr 28, 2022
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
ephraimbuddy
pushed a commit
that referenced
this pull request
May 8, 2022
(cherry picked from commit 1c886ea)
ephraimbuddy
pushed a commit
that referenced
this pull request
May 21, 2022
(cherry picked from commit 1c886ea)
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from my PR to FAB dpgaspar/Flask-AppBuilder#1775.
This PR moves one line around so the
user.last_loginfield is only updated when the user has successfully authenticated.Without this PR the
user.last_loginfield is not very useful, as thelast_loginfield would be set to the last time anybody - successfully or unsuccessfully - attempted to login, instead of the datetime of the last successful authentication attempt.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.