Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document built in Timetables #23099

Merged
merged 18 commits into from
Jun 30, 2022
Merged

Conversation

collinmcnulty
Copy link
Contributor

Adding descriptions of the 3 built in, user-facing timetables to the Timetables doc page.

@collinmcnulty
Copy link
Contributor Author

@jedcunningham adding this documentation as per your suggestion.

docs/apache-airflow/concepts/timetable.rst Show resolved Hide resolved
docs/apache-airflow/concepts/timetable.rst Outdated Show resolved Hide resolved
docs/apache-airflow/concepts/timetable.rst Outdated Show resolved Hide resolved
docs/apache-airflow/concepts/timetable.rst Outdated Show resolved Hide resolved
docs/apache-airflow/concepts/timetable.rst Outdated Show resolved Hide resolved
docs/apache-airflow/concepts/timetable.rst Outdated Show resolved Hide resolved
docs/apache-airflow/concepts/timetable.rst Outdated Show resolved Hide resolved
docs/apache-airflow/concepts/timetable.rst Outdated Show resolved Hide resolved
docs/apache-airflow/concepts/timetable.rst Outdated Show resolved Hide resolved
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Apr 19, 2022
@github-actions
Copy link

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@uranusjr
Copy link
Member

Not sure what’s going on but code blocks are failing. Maybe the imports must be added?

@eladkal
Copy link
Contributor

eladkal commented Jun 29, 2022

@collinmcnulty can you please check the test failures?

@ashb
Copy link
Member

ashb commented Jun 29, 2022

@collinmcnulty Something went very arry here with this PR, shout if you want a hand rebasing it.

@collinmcnulty
Copy link
Contributor Author

Oh geez. Yeah, I thought I did the rebasing but obviously things fell apart.

Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits.

docs/apache-airflow/concepts/timetable.rst Outdated Show resolved Hide resolved
docs/apache-airflow/concepts/timetable.rst Outdated Show resolved Hide resolved
docs/apache-airflow/concepts/timetable.rst Outdated Show resolved Hide resolved
docs/apache-airflow/concepts/timetable.rst Outdated Show resolved Hide resolved
docs/apache-airflow/concepts/timetable.rst Outdated Show resolved Hide resolved
@jedcunningham jedcunningham added this to the Airflow 2.3.3 milestone Jun 29, 2022
@jedcunningham jedcunningham added the type:doc-only Changelog: Doc Only label Jun 29, 2022
@collinmcnulty
Copy link
Contributor Author

I'm at a loss. Do the example blocks need to be fully functional standalone python code? Is there some way to tell the CI that they're not?

@uranusjr
Copy link
Member

They don’t need to be strictly functional, but must be valid Python syntax. So the easiest way to get around the checks is to just add

def dag():
    ...

under those decorators.

@jedcunningham jedcunningham merged commit 056b8cf into apache:main Jun 30, 2022
@jedcunningham
Copy link
Member

🎉 Thanks Collin!

ephraimbuddy pushed a commit that referenced this pull request Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:documentation okay to merge It's ok to merge this PR as it does not require more tests type:doc-only Changelog: Doc Only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants