-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document built in Timetables #23099
Document built in Timetables #23099
Conversation
@jedcunningham adding this documentation as per your suggestion. |
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Not sure what’s going on but code blocks are failing. Maybe the imports must be added? |
@collinmcnulty can you please check the test failures? |
@collinmcnulty Something went very arry here with this PR, shout if you want a hand rebasing it. |
Oh geez. Yeah, I thought I did the rebasing but obviously things fell apart. |
Co-authored-by: Jed Cunningham <[email protected]>
Co-authored-by: Tzu-ping Chung <[email protected]>
Co-authored-by: Tzu-ping Chung <[email protected]>
Co-authored-by: Tzu-ping Chung <[email protected]>
Co-authored-by: Tzu-ping Chung <[email protected]>
8e6d344
to
63f9c49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple nits.
Co-authored-by: Jed Cunningham <[email protected]>
Co-authored-by: Jed Cunningham <[email protected]>
I'm at a loss. Do the example blocks need to be fully functional standalone python code? Is there some way to tell the CI that they're not? |
They don’t need to be strictly functional, but must be valid Python syntax. So the easiest way to get around the checks is to just add def dag():
... under those decorators. |
🎉 Thanks Collin! |
(cherry picked from commit 056b8cf)
Adding descriptions of the 3 built in, user-facing timetables to the Timetables doc page.