Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GoogleDriveToGCSOperator: Remove destination_bucket, destination_object #23072

Merged
merged 1 commit into from
Apr 25, 2022
Merged

GoogleDriveToGCSOperator: Remove destination_bucket, destination_object #23072

merged 1 commit into from
Apr 25, 2022

Conversation

eladkal
Copy link
Contributor

@eladkal eladkal commented Apr 19, 2022

The next Google provider release is major (breaking changes) so I want to take the opportunity to clean up some deprecations

Related: #23050

@eladkal eladkal requested review from potiuk and mik-laj April 19, 2022 07:00
@eladkal eladkal requested a review from turbaszek as a code owner April 19, 2022 07:00
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Apr 19, 2022
ferruzzi
ferruzzi approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM

@potiuk potiuk merged commit 0373fb0 into apache:main Apr 25, 2022
@eladkal eladkal deleted the gdrive branch April 25, 2022 18:23
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 26, 2022
@potiuk potiuk mentioned this pull request May 11, 2022
Closed
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferruzzi ferruzzi ferruzzi approved these changes

@potiuk potiuk potiuk approved these changes

@mik-laj mik-laj Awaiting requested review from mik-laj

@turbaszek turbaszek Awaiting requested review from turbaszek

Assignees
No one assigned
Labels
area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:google Google (including GCP) related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eladkal @potiuk @ferruzzi @ephraimbuddy