Update ImportError items instead of deleting and recreating them #22928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
ephraimbuddy
force-pushed
the
fix-dagimporterror-recreation
branch
2 times, most recently
from
c1281d6 to
7e155a9
Compare
uranusjr
reviewed
Apr 12, 2022
Each time a dag with import error is parsed, the ImportError record is deleted and a new record is created. For example, say I have two dags with import errors, initially, the import error id will be dag_1:import_error.id=1, dag2:import_error.id=2. In the next dag parsing, the import error will increase. dag_1:import_error.id=3, dag_2:import_error.id=4 and it continues like that. This makes it impossible for the get import error REST API endpoint to be consistent This PR fixes this issue by updating the existing record and creating a new one if no record exists
ephraimbuddy
force-pushed
the
fix-dagimporterror-recreation
branch
from
7e155a9 to
08cb0e4
Compare
potiuk
approved these changes
Apr 14, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
jedcunningham
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each time a dag with import error is parsed, the ImportError record is deleted
and a new record is created. For example, say I have two dags with import errors,
initially, the import error id will be dag_1:import_error.id=1, dag2:import_error.id=2.
In the next dag parsing, the import error will increase. dag_1:import_error.id=3,
dag_2:import_error.id=4 and it continues like that.
This makes it impossible for the get import error REST API endpoint to be consistent
This PR fixes this issue by updating the existing record and creating a new one if no record
exists