Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SmoothOperator #22813

Merged
merged 5 commits into from
Apr 11, 2022
Merged

Conversation

turbaszek
Copy link
Member

Easter is coming so I just came with idea of an harmless easter egg 😄


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Easter is coming so I just came with idea of an easter egg.
@turbaszek turbaszek requested review from potiuk and eladkal April 7, 2022 12:12
@boring-cyborg boring-cyborg bot added the area:core-operators Operators, Sensors and hooks within Core Airflow label Apr 7, 2022
@potiuk
Copy link
Member

potiuk commented Apr 7, 2022

Will it actually log any outpit :) ? I think not as Dummy Opertor's execute is not well.. executed :)?

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Apr 7, 2022
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@uranusjr
Copy link
Member

uranusjr commented Apr 7, 2022

This operator may be too criminal to use in production

@uranusjr
Copy link
Member

uranusjr commented Apr 7, 2022

Yes the inherits_from_dummy_operator check would kick in to not run execute.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the inherits_from_dummy_operator check would kick in to not run execute.

Well. Then I think we can't merge it because it DOES NOT WORK AS ADVERTISED!

@turbaszek turbaszek requested a review from mik-laj as a code owner April 7, 2022 22:51
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now - you talking to me :)

@potiuk
Copy link
Member

potiuk commented Apr 8, 2022

But even smooth operator needs some ❤️ when it comes to static checks :D

airflow/operators/smooth.py Outdated Show resolved Hide resolved
@turbaszek turbaszek requested a review from eladkal April 10, 2022 16:12
@potiuk
Copy link
Member

potiuk commented Apr 10, 2022

Static checks are Sade, ehm SAD.

@potiuk
Copy link
Member

potiuk commented Apr 11, 2022

Not SADE any more and just random failure. Merging :)

@potiuk
Copy link
Member

potiuk commented Apr 11, 2022

Just in time for 2.3.0.

We could not wait for SmoothOperator. It's been highly requested feature by many.

@potiuk potiuk merged commit bc10265 into apache:main Apr 11, 2022
@jedcunningham jedcunningham added the type:new-feature Changelog: New Features label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow full tests needed We need to run full set of tests for this PR to merge type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants