-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SmoothOperator #22813
Add SmoothOperator #22813
Conversation
Easter is coming so I just came with idea of an easter egg.
Will it actually log any outpit :) ? I think not as Dummy Opertor's execute is not well.. executed :)? |
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
This operator may be too criminal to use in production |
Yes the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the
inherits_from_dummy_operator
check would kick in to not runexecute
.
Well. Then I think we can't merge it because it DOES NOT WORK AS ADVERTISED!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now - you talking to me :)
But even smooth operator needs some ❤️ when it comes to static checks :D |
Static checks are Sade, ehm SAD. |
Not SADE any more and just random failure. Merging :) |
Just in time for 2.3.0. We could not wait for SmoothOperator. It's been highly requested feature by many. |
Easter is coming so I just came with idea of an harmless easter egg 😄
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.