-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc and sample dag for SqlToS3Operator #22603
Conversation
================================== | ||
|
||
Use SqlToS3Operator to copy data from a SQL server to an Amazon Simple Storage Service (S3) file. | ||
SqlToS3Operator is compatible with any SQL connection as long as it is defined in Connections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not quite right. It support only hooks that implemented get_pandas_df
I'm not so though how to explain it in the doc. The users who read this might not know what get_pandas_df
is. Maybe we should add something like "as long as the SQL hook has function that converts the sql result to pandas dataframe" (or something in that area)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're correct! Thanks for pointing it out. I used your sentence and added examples to try to make it easier for the user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, nice catch!
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Add doc and sample dag for SqlToS3Operator