Update black precommit #22521
Merged
Update black precommit #22521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedcunningham
requested review from
potiuk,
ashb,
mik-laj and
turbaszek
as code owners
boring-cyborg
bot
added
area:dev-tools
area:logging
area:providers
provider:google
uranusjr
reviewed
Mar 25, 2022
| @@ -113,7 +113,7 @@ def my_after_func(retry_state): | |||
| else: | |||
| self.retry_args = dict( | |||
| stop=stop_after_attempt(self.retry_limit), | |||
| wait=wait_exponential(min=self.retry_delay, max=(2 ** retry_limit)), | |||
| wait=wait_exponential(min=self.retry_delay, max=(2**retry_limit)), | |||
There was a problem hiding this comment.
Hmm that’s an interesting change of style.
There was a problem hiding this comment.
In psf/black#538 (where the change was made), it mentions that PEP 8 advises to only use whitespace to help make operator precedence more clear (** has a high precedence), and to not use it otherwise.
uranusjr
approved these changes
Mar 25, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
Use latest version of black, drop py36, and add py310.
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
added
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use latest version of black (first "non-beta" release 🎉), drop py36, and add py310.