Fixed bug where CloudBuildRunBuildTriggerOperator fail to find build id.
#22419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e 'build' apache#22398 * Fixed issue where the `_get_build_id_from_operation` was accepting the Operation class instead of an instance of operation in the `create_build` function. * Added an assertion to verify the above fix.
boring-cyborg
bot
added
area:providers
provider:google
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
|
Can you fix it also for and |
…ere unable to find the build id The `retry_build` and `run_build_trigger` functions in cloud_build.py were incorrectly passing the class `Operation` to the helper function `_get_build_id_from_operation` instead of the operation instance.
eladkal
approved these changes
Mar 23, 2022
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
…ty-object-has-no-attribute-build
eladkal
changed the title
CloudBuildRunBuildTriggerOperator fail to find build id.
|
Awesome work, congrats on your first merged pull request! |
stephenoken
deleted the
Fix-CloudBuildRunBuildTriggerOperator-property-object-has-no-attribute-build
branch
46 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue where the
_get_build_id_from_operationwas accepting the Operation class instead of an instance of operation in thecreate_buildfunction. This led to an Airflow exception being thrown whenever a cloud build job was being created.closes: #22398
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.