Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic connection type #22310

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Add generic connection type #22310

merged 1 commit into from
Mar 16, 2022

Conversation

malthe
Copy link
Contributor

@malthe malthe commented Mar 16, 2022

See #20350.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Mar 16, 2022
@eladkal
Copy link
Contributor

eladkal commented Mar 16, 2022

Just to mention that Airflow doesn't enforce conn_type - so it doesn't really matter what user will choose.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 16, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@malthe
Copy link
Contributor Author

malthe commented Mar 16, 2022

@eladkal yeah it's just not to add confusion about a connection entry. I'd rather have Generic than AWS (unless of course it really is an AWS connection).

@potiuk
Copy link
Member

potiuk commented Mar 16, 2022

Yeah. I think it's good to have it to avoid confusion from the users. We had the same problem with email connection. This is really to give the right answer to the users who seek for it in the UI and don't realize they could use HTTP for example

@potiuk potiuk merged commit 6d1d53b into main Mar 16, 2022
@eladkal eladkal deleted the generic-connection-type branch March 16, 2022 17:21
shuhoy pushed a commit to shuhoy/airflow that referenced this pull request Mar 17, 2022
@eladkal eladkal added this to the Airflow 2.2.6 milestone Mar 24, 2022
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants