-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow migration jobs and init containers to be optional #22195
allow migration jobs and init containers to be optional #22195
Conversation
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also should add some tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I wonder if we should have a single waitForMigrations
flag instead of individual ones? Haven't really thought it through though.
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
@jedcunningham yeah I wasn't sure if a single flag would be better and went with more flexibility. |
Awesome work, congrats on your first merged pull request! |
Thanks @ajbosco! Congrats on your first commit, at least in the last few years (bot got confused 🤷♂️) 🎉 |
Currently, the Helm Chart forces using the migration job to run db migrations, but this has a few issues (not supporting
--wait
and--atomic
helm installs being the biggest. This PR makes that job (and the accompanying init containers on deployments) optional. All defaults match the existing behavior so nothing should change for current Chart users.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.