-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show import error for 'airflow dags list' CLI command #21991
Conversation
Won't that cause problem for scripts that process the output of this command? I think we should display import errors on stderr. |
Related PR: #15087 |
2424a13
to
d0ad999
Compare
What's your opinion about having |
@ephraimbuddy, For me, displaying an error on stderr without any options is also OK. In the above-mentioned PR, I proposed to add a separate command as this would allow us to write scripts that process these import errors, but we can do it as a separate contribution. |
When there's an import error in a dag, the dag doesn't show up in the list of dags and there's no indication that there's an import error. This PR fixes that
Co-authored-by: Jed Cunningham <[email protected]>
d0ad999
to
ea28107
Compare
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Co-authored-by: Jed Cunningham <[email protected]>
When there's an import error in a dag, the dag doesn't show up in the list of dags
and there's no indication that there's an import error.
This PR fixes that