Add compat shim for SQLAlchemy to avoid warnings #21959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQLALchemy 1.4 is introducing a ton of deprecation warnings to our code base. They need to be fixed eventually if we want to support SQLALchemy 2.0, so this introduce shims to ease the migration in the future, while squelching the warnings in the mean time.
boring-cyborg
bot
added
area:serialization
area:webserver
kaxil
approved these changes
Mar 3, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
ashb
approved these changes
Mar 3, 2022
ephraimbuddy
added
the
type:misc/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLALchemy 1.4 is introducing a ton of deprecation warnings to our code base. They need to be fixed eventually if we want to support SQLALchemy 2.0, so this introduce shims to ease the migration in the future, while squelching the warnings in the mean time.
This cleans up 76 deprecation warnings emitted by
test_dag_serialization.py, from 827 to 743. Yeah that’s still a ton of warnings, although a good portion are fromdays_agousages in our example DAGs.