Add per-DAG delete permissions #21938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
reviewed
Mar 2, 2022
kaxil
reviewed
Mar 2, 2022
blag
force-pushed
the
dag-level-delete-perms
branch
2 times, most recently
from
b2c2031 to
2f18b80
Compare
|
@mik-laj Can you be more specific with that you'd like me to document here? As far as I can tell, this PR is really just making delete permissions behave the way they are already implied by the documentation to behave. |
blag
requested review from
jhtimmins,
ryanahamilton,
ashb,
bbovenzi and
XD-DENG
as code owners
blag
changed the title
kaxil
reviewed
Mar 3, 2022
blag
force-pushed
the
dag-level-delete-perms
branch
from
2f18b80 to
749205b
Compare
Co-authored-by: Kaxil Naik <[email protected]>
blag
force-pushed
the
dag-level-delete-perms
branch
from
1bdaaf1 to
59a6f4b
Compare
kaxil
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds per-DAG delete permissions and extends the
sync-permssubcommand to add delete permissions to the database for all existing DAGs (it does not, however, grant any of the new DAG delete permissions to any roles).TODO:
Documentation