Enhance magic methods on XComArg for UX #21882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementing Python's magic methods for purposes not matching their original design can have unwanted consequences due to default interactions between those methods. This implements a custom __iter__ so the custom __getitem__ does not trigger the default __iter__ behavior and result in bad run-time behavior.
>>> class A:
... def __getitem__(self, name): print name; return repr(name)
...
>>> a = A()
>>> next(iter(a))
0
'0'OK that is surprising. Unexpected Python magic! |
malthe
approved these changes
Mar 2, 2022
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
uranusjr
force-pushed
the
xcom-arg-index-lookup-fail
branch
from
8550636 to
6937ca5
Compare
dstandish
approved these changes
Mar 2, 2022
Actually two short tests generating the exceptions would be nice :) |
|
Tests added |
potiuk
approved these changes
Mar 3, 2022
|
random ci failure. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #21853. We can do better.