add an option for run id in the ui trigger screen

[talnagar]

Added an option for custom run_id in the trigger dag screen.
this option was already supported in the API.
This commit includes:

• changes to the static template of the trigger screen
• extraction of the run_id in the views.py
• changes to models/dagrun.py - filter dag runs by run_id if exists or execution date
• unittest for: triggering dagrun with and without run_id, handling duplicate run_id

closes: #21336

Before:

After:

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: [email protected]
  Slack: https://s.apache.org/airflow-slack

[ashb]

Thanks for the PR!

When making UI changes it is helpful to the reviewers if you include before and after screenshots in the PR description

[talnagar]

thanks for the feedback, I added the screen shots to the PR.
I tried to use the same css classes I saw on other templates but wasn't sure if there is some tests that I need to do for different screen types/resolutions?

[bbovenzi]

Can we handle duplicate runIds more elegantly?

[talnagar]

@bbovenzi I am trying to reproduce this error and write a unittest for it.
When I trigger tasks with duplicates in my local env I see the issue is handled and an error msg is shown:

can you please write how did you produce this error?

[bbovenzi]

can you please write how did you produce this error?

Actually I'm not sure. I just tried again and the correct error was thrown.

[talnagar]

@bbovenzi @uranusjr I just committed updates to the code:

• moved dag filtration to model now using sqlalchemy.
• added a unittest for checking handling of duplicate run_id.
  I would appreciate your feedback.

[bbovenzi]

UI-wise this looks good to me.

[github-actions]

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

[uranusjr]

Logic looks good to me, but can you change the code to not use DagRun.find(), and leave the function unchanged? I don’t think this new logic is general enough that we should risk breaking backward compatibility. (Eventually I feel DagRun.find() should probably be removed entirely, but before that we would do better to avoid using it in new code.)

[talnagar]

@uranusjr not sure I understand what you mean. add a separate function in models/dagrun.py to look for duplicate run ids instead of using the existing find?
I see there is a function for finding duplicates DagRun.find_duplicate():

airflow/airflow/models/dagrun.py

Line 365 in 8c3f479

def find_duplicate(

maybe I should switch to using it instead of DagRun.find()

[uranusjr]

Oh, I was thinking we don’t need to add a function and could just use SQLAlchemy directly in trigger. But find_duplicate is actually better, nice find! I did not even know it exists.

[boring-cyborg]

Awesome work, congrats on your first merged pull request!

[curlup]

which version is this included in? and does anyone knows if we can easily backport? thanks!

[ashb]

This is not yet included in any release, it will be in 2.3.0 which we aim to get out in a week or two