In DAG dependency detector, use class type instead of class name, 2nd attempt #21706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You definietely need to rebase: |
davidavdav
force-pushed
the
dagdependence
branch
from
1e3ad5d to
9dac731
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
davidavdav
force-pushed
the
dagdependence
branch
from
9dac731 to
03c1f21
Compare
eladkal
removed
the
stale
eladkal
reviewed
Apr 14, 2022
eladkal
reviewed
Apr 14, 2022
eladkal
reviewed
Apr 14, 2022
davidavdav
force-pushed
the
dagdependence
branch
from
b5088d3 to
7699a62
Compare
eladkal
approved these changes
Apr 14, 2022
There was a problem hiding this comment.
Looks OK to me.
cc @kaxil @dstandish as you reviewed the previous stale PR
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
Add tests for DAG dependency detector Adhere to style norms Add a line to make black happy Don't call an Operator just Trigger Use `class_` for class variables Fix static check isort imports Simplipy test class and split into two tests
ashb
approved these changes
Apr 22, 2022
|
Awesome work, congrats on your first merged pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #19683, which got closed by a bot.