-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin Markupsafe until we are able to upgrade Flask/Jinja #21664
Conversation
2539062
to
08d0095
Compare
Markupsafe 2.1.0 breaks with error: import name 'soft_unicode' from 'markupsafe'. This should be removed when either this issue is closed: pallets/markupsafe#284 or when we will be able to upgrade JINJA to newer version (currently limited due to Flask and Flask Application Builder)
08d0095
to
0fde263
Compare
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Markupsafe 2.1.0 breaks with error: import name 'soft_unicode' from 'markupsafe'. This should be removed when either this issue is closed: pallets/markupsafe#284 or when we will be able to upgrade JINJA to newer version (currently limited due to Flask and Flask Application Builder) (cherry picked from commit 366c66b)
Yeah needs to be included in 2.2.4 |
Markupsafe 2.1.0 breaks with error: import name 'soft_unicode' from 'markupsafe' This should be removed when either this issue is closed: pallets/markupsafe#284 or when we will be able to upgrade JINJA to newer version (currently limited due to Flask and Flask Application Builder) apache/airflow#21664
already did :) |
Thanks @potiuk @eladkal and @kaxil for the quick fix here! This actually does block new airflow installs, so really appreciate how quickly you two moved for this.
|
It shouldn't really have any effect if you install airflow from constraint: |
Oh interesting, I wasn't aware of that method of installation. If other people find this, this seems to work for me:
Thanks! |
Markupsafe 2.1.0 breaks with error: import name 'soft_unicode' from 'markupsafe' This should be removed when either this issue is closed: pallets/markupsafe#284 or when we will be able to upgrade JINJA to newer version (currently limited due to Flask and Flask Application Builder) apache/airflow#21664
Markupsafe 2.1.0 breaks with error: import name 'soft_unicode' from 'markupsafe'
This should be removed when either this issue is closed:
pallets/markupsafe#284
or when we will be able to upgrade JINJA to newer version (currently limited due to Flask and
Flask Application Builder)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.