Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action log on Browse Views #21569

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Conversation

pingzh
Copy link
Contributor

@pingzh pingzh commented Feb 15, 2022

Current, actions under Browse are not logged.

request.values is a MultiDict, items() with default multi=False only returns one of the values with the same key

After the fix:

image


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Feb 15, 2022
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Feb 15, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@pingzh pingzh force-pushed the pingzh-action-logging-in-browse branch from 92be59f to d96a515 Compare February 15, 2022 18:03
@pingzh pingzh force-pushed the pingzh-action-logging-in-browse branch from d96a515 to 1f52ca8 Compare February 15, 2022 20:07
@kaxil kaxil merged commit a55d714 into apache:main Feb 15, 2022
@kaxil kaxil added this to the Airflow 2.3.0 milestone Feb 15, 2022
@pingzh pingzh deleted the pingzh-action-logging-in-browse branch February 15, 2022 22:01
@jedcunningham jedcunningham added the type:improvement Changelog: Improvements label Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants