-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py files doesn't have to be checked is_zipfiles in process_files #21538
py files doesn't have to be checked is_zipfiles in process_files #21538
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with this change. Looks reasonable. It has (very improbable) compatibility if someone would have stored a zip file as .py file. This is unlikely, and I think it does not "count" as backwards compatiblity, but this behaviour change should be mentioned in UPDATING.md
Also I think we need someone else from committers to also agree that this not "incompatible envough" to classify as backwards-incompatible.
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
7ee80b9
to
d23d3fa
Compare
Without extra changes, I rebased my PR branch.
|
@uranusjr |
@sungpeo can you add this to UPDATING.md? Thanks! |
I added description for change of this PR to main in UDPAING.md. |
Co-authored-by: Jed Cunningham <[email protected]>
Awesome work, congrats on your first merged pull request! |
@sungpeo, thanks! Congrats on your first commit 🎉 |
py files doesn't have to be checked with is_zipfiles in process_files
like find_dag_file_paths in file.
airflow/airflow/utils/file.py
Lines 192 to 201 in 0a2d0d1
zipfile.is_zipfile could take longer than anticipated in case of remote file mount (DAG_DIR).
So, I want py files (generaly almost dag files are py) skip to check is_zipfile.
(It is simple change. Exist tests cover this one)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.