-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add another way to dynamically generate DAGs to docs #21297
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
I like this example. Taking a look at this, it seems this section on "dynamic dag generation" is getting rather long and starting to look like more of a "how to" than a "best practices". I think it might be best if we create a "how to" page called "dynamic dag generation" or perhaps "Config-based dag generation". Then in the "best practices" page we can keep a more succinct message about what really is the "best practice" we're trying to emphasize in this area, and we can link to the how-to ("for more details on dag generation, see our how-to..."). Would you be interested in takking this on as part of this PR? |
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Might be a good idea actuallly if you want to do it @makrushin-evgenii :) |
You're right. Want to do it this way, but forgot about the "How To" page. I'll make changes in a few days A few clarifications:
|
I was thinking move all of it but just keep any salient points that really are "best practices". I think the key point there was really that if you are generating a dag from a config to be mindful of network IO because dags are parsed frequently ( though less so now than in the past). IIRC everything else is more subjective, but still helpful examples to have in a how-to. But of course apply your own judgment too about what makes sense. I think external links are fine |
Could you please rebase this one @makrushin-evgenii if it fails? |
add another way to dynamically generate DAGs
@potiuk, i fixed all failed checks. What else should I do? |
Awesome work, congrats on your first merged pull request! |
This PR created as a result of discussion #21278