Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log trigger status only if at least one is running #21191

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Log trigger status only if at least one is running #21191

merged 1 commit into from
Feb 1, 2022

Conversation

malthe
Copy link
Contributor

@malthe malthe commented Jan 28, 2022

Previously, every minute a line would be logged such as:

{triggerer_job.py:251} INFO - 0 triggers currently running

Seems a little excessive.

@malthe malthe requested a review from dstandish as a code owner January 28, 2022 17:56
@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Jan 28, 2022
@dstandish
Copy link
Contributor

isn't it nice to know it's at least doing something? 1x/minute does not seem super crazy.....

@malthe
Copy link
Contributor Author

malthe commented Jan 28, 2022

I suppose one could log it on DEBUG level – but simply being on doesn't really warrant logging in my book – especially because Airflow will log a warning if there is no triggerer running and there are deferred tasks.

@potiuk potiuk merged commit 32d177c into apache:main Feb 1, 2022
@jedcunningham jedcunningham added the type:improvement Changelog: Improvements label Mar 1, 2022
@ephraimbuddy ephraimbuddy modified the milestone: Airflow 2.2.5 Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@o-nikolas o-nikolas o-nikolas approved these changes

@potiuk potiuk potiuk approved these changes

@dstandish dstandish Awaiting requested review from dstandish dstandish is a code owner

Assignees
No one assigned
Labels
area:Scheduler including HA (high availability) scheduler type:improvement Changelog: Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@malthe @dstandish @potiuk @o-nikolas @ephraimbuddy @jedcunningham