Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Re)fix Dangling rows moving with MySQL+Replication #21061

Merged
merged 2 commits into from
Jan 24, 2022
Merged

(Re)fix Dangling rows moving with MySQL+Replication #21061

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d92c72
(Re)fix Dangling rows moving with MySQL+Replication
ashb Jan 24, 2022
6e73b96
Update airflow/utils/db.py
ashb Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion airflow/utils/db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,8 +860,15 @@ def _move_dangling_data_to_new_table(
cte_sql = stmt.ctes[cte]

session.execute(f"WITH {cte_sql} SELECT source.* INTO {target_table_name} FROM source")
elif dialect_name == "mysql":
# MySQL with replication needs this split in to two queries, so just do it for all MySQL
# ERROR 1786 (HY000): Statement violates GTID consistency: CREATE TABLE ... SELECT.
session.execute(f"CREATE TABLE {target_table_name} LIKE {source_table.name}")
session.execute(
f"INSERT INTO {target_table_name} {source_query.selectable.compile(bind=session.get_bind())}"
)
else:
# Postgres, MySQL and SQLite all support the same "create as select"
# Postgres and SQLite both support the same "CREATE TABLE a AS SELECT ..." syntax
session.execute(
f"CREATE TABLE {target_table_name} AS {source_query.selectable.compile(bind=session.get_bind())}"
)
Expand Down