Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing statsd metric for failing SLA Callback notification #20924

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

Jorricks
Copy link
Contributor

There is a statsd metric for failing email notifications but not for failing callbacks.
This PR makes it easier to monitor for failing callbacks to spot them sooner.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added area:Scheduler including HA (high availability) scheduler kind:documentation labels Jan 18, 2022
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jan 20, 2022
@Jorricks
Copy link
Contributor Author

Jorricks commented Feb 9, 2022

@uranusjr is there a new policy to not merge MRs right away? I am wondering what we are waiting for :)?

@potiuk
Copy link
Member

potiuk commented Feb 9, 2022

@uranusjr is there a new policy to not merge MRs right away? I am wondering what we are waiting for :)?

I think it was simply overlooked. If you look at the "traffic" in our PRs, you might understand that sometimes some things might simply slip under the radar. Generally speaking it's the author's responsibiliyt to Gently Ping if they see such a situation might happen. You, as author are ultimately mostly interested about this and I bet you have probably orders of magnitude less of PRs that you authored rather than any of the maintainers to approve/merge.

Little empathy goes a long way :). Just gently ping next time.

@potiuk potiuk merged commit 338f19e into apache:main Feb 9, 2022
@Jorricks
Copy link
Contributor Author

Jorricks commented Feb 9, 2022

@uranusjr is there a new policy to not merge MRs right away? I am wondering what we are waiting for :)?

I think it was simply overlooked. If you look at the "traffic" in our PRs, you might understand that sometimes some things might simply slip under the radar. Generally speaking it's the author's responsibiliyt to Gently Ping if they see such a situation might happen. You, as author are ultimately mostly interested about this and I bet you have probably orders of magnitude less of PRs that you authored rather than any of the maintainers to approve/merge.

Little empathy goes a long way :). Just gently ping next time.

I understand. I didn't mean anything by my comment, I was just really wondering if I can find the policy on merging PRs somewhere. I appreciate all the work you are doing 🙏
Sorry if it came over harsh

@potiuk
Copy link
Member

potiuk commented Feb 9, 2022

Sorry if it came over harsh

:) No worries. It just came a bit harsh by the fact that you kinda abandoned it for 20 days (and obviously we did too :) )

@jedcunningham jedcunningham added the type:new-feature Changelog: New Features label Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler including HA (high availability) scheduler full tests needed We need to run full set of tests for this PR to merge kind:documentation type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants