Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI page title to allow for Markup #20888

Merged
merged 5 commits into from
Jan 19, 2022
Merged

UI page title to allow for Markup #20888

merged 5 commits into from
Jan 19, 2022

Conversation

PApostol
Copy link
Contributor

@PApostol PApostol commented Jan 15, 2022 •
edited
Loading

Set instance_name_has_markup = True in airflow.cfg to render instance_name with Markup.

Closes #20877.

@boring-cyborg boring-cyborg bot added area:webserver Webserver related Issues kind:documentation labels Jan 15, 2022
@wolfier
Copy link
Contributor

wolfier commented Jan 18, 2022

Nice change! lgtm

@ashb
Copy link
Member

ashb commented Jan 18, 2022

Hmmm for some reason this sits a little uneasily with me, but I can't actually think of any way it would go wrong (in an exploitable way)

@PApostol
Copy link
Contributor Author

Hmmm for some reason this sits a little uneasily with me, but I can't actually think of any way it would go wrong (in an exploitable way)

I understand where you're coming from, but essentially it's not too different from the UIAlert code (that's where I got the idea from).

@kaxil kaxil merged commit a65555e into apache:main Jan 19, 2022
@PApostol PApostol deleted the allow-for-markup-in-ui-page-title branch January 19, 2022 13:11
@eladkal eladkal added this to the Airflow 2.3.0 milestone Feb 11, 2022
@jedcunningham jedcunningham added the type:new-feature Changelog: New Features label Mar 1, 2022
@IAL32 IAL32 mentioned this pull request Jan 12, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaxil kaxil kaxil approved these changes

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

Assignees
No one assigned
Labels
area:webserver Webserver related Issues kind:documentation type:new-feature Changelog: New Features
Projects
None yet
Milestone
Airflow 2.3.0
Development

Successfully merging this pull request may close these issues.

Allow for Markup in UI page title
6 participants
@PApostol @wolfier @ashb @kaxil @eladkal @jedcunningham