Add downgrade to some FAB migrations #20874
Conversation
ephraimbuddy
force-pushed
the
fab-downgrades
branch
from
7f975d9 to
a94aa9b
Compare
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
airflow/migrations/versions/849da589634d_prefix_dag_permissions.py
Outdated
Show resolved
Hide resolved
ephraimbuddy
force-pushed
the
fab-downgrades
branch
from
ee3a896 to
c7a6aeb
Compare
| @@ -319,3 +344,7 @@ def upgrade(): | |||
|
|
|||
| def downgrade(): | |||
| """Unapply Resource based permissions.""" | |||
| log = logging.getLogger() | |||
| handlers = log.handlers[:] | |||
There was a problem hiding this comment.
Worth adding a note why this is needed?
There was a problem hiding this comment.
I think this logging is not necessary, however, I copied it from the upgrade function
| db = SQLA() | ||
| db.session = settings.Session | ||
| undo_migrate_to_new_dag_permissions(db) | ||
| db.session.commit() |
There was a problem hiding this comment.
This commit seems unnecessary?
There was a problem hiding this comment.
Also from what I can tell undo_migrate_to_new_dag_permissions only uses db.session; why not just pass that into the function, but the entire db object?
There are some FAB migrations that don't have downgrades. This PR fixes it
ephraimbuddy
force-pushed
the
fab-downgrades
branch
from
c7a6aeb to
06a2081
Compare
There are some FAB migrations that don't have downgrades. This PR fixes it (cherry picked from commit f964fd4)
There are some FAB migrations that don't have downgrades. This PR fixes it (cherry picked from commit f964fd4)
There are some FAB migrations that don't have downgrades.
This PR fixes it
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.