Speedup liveness probe for scheduler and triggerer #20833
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:CLI
area:helm-chart
dstandish
changed the title
Liveness probe is submitted through `/entrypoint` which by default runs `airflow db check`. This can be slow. We can disable by setting `CONNECTION_CHECK_MAX_COUNT=0`.
dstandish
force-pushed
the
sched-trig-liveness-speedup
branch
from
f2a6e1f to
1f9a1b0
Compare
jedcunningham
approved these changes
Jan 12, 2022
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
kaxil
approved these changes
Jan 12, 2022
mik-laj
approved these changes
Jan 12, 2022
2 tasks
dstandish
added a commit
to astronomer/airflow
that referenced
this pull request
Jan 25, 2022
PR apache#20833 tried to speed up the liveness probe by setting variable CONNECTION_CHECK_MAX_COUNT=0 which disables a connectivity check in `/entrypoint` (which turns out to be slow). Unfortunately the approach taken doesn't work; we have to use `sh -c exec` instead.
jedcunningham
pushed a commit
that referenced
this pull request
Jan 26, 2022
PR #20833 tried to speed up the liveness probe by setting variable CONNECTION_CHECK_MAX_COUNT=0 which disables a connectivity check in `/entrypoint` (which turns out to be slow). Unfortunately the approach taken doesn't work; we have to use `sh -c exec` instead.
15 tasks
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 10, 2022
PR apache/airflow#20833 tried to speed up the liveness probe by setting variable CONNECTION_CHECK_MAX_COUNT=0 which disables a connectivity check in `/entrypoint` (which turns out to be slow). Unfortunately the approach taken doesn't work; we have to use `sh -c exec` instead. GitOrigin-RevId: bca5caf3611fc8659b8bd5fdcddc04dc5b104344
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Aug 27, 2022
PR apache/airflow#20833 tried to speed up the liveness probe by setting variable CONNECTION_CHECK_MAX_COUNT=0 which disables a connectivity check in `/entrypoint` (which turns out to be slow). Unfortunately the approach taken doesn't work; we have to use `sh -c exec` instead. GitOrigin-RevId: bca5caf3611fc8659b8bd5fdcddc04dc5b104344
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 4, 2022
PR apache/airflow#20833 tried to speed up the liveness probe by setting variable CONNECTION_CHECK_MAX_COUNT=0 which disables a connectivity check in `/entrypoint` (which turns out to be slow). Unfortunately the approach taken doesn't work; we have to use `sh -c exec` instead. GitOrigin-RevId: bca5caf3611fc8659b8bd5fdcddc04dc5b104344
aglipska
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 7, 2022
PR apache/airflow#20833 tried to speed up the liveness probe by setting variable CONNECTION_CHECK_MAX_COUNT=0 which disables a connectivity check in `/entrypoint` (which turns out to be slow). Unfortunately the approach taken doesn't work; we have to use `sh -c exec` instead. GitOrigin-RevId: bca5caf3611fc8659b8bd5fdcddc04dc5b104344
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Dec 7, 2022
PR apache/airflow#20833 tried to speed up the liveness probe by setting variable CONNECTION_CHECK_MAX_COUNT=0 which disables a connectivity check in `/entrypoint` (which turns out to be slow). Unfortunately the approach taken doesn't work; we have to use `sh -c exec` instead. GitOrigin-RevId: bca5caf3611fc8659b8bd5fdcddc04dc5b104344
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jan 27, 2023
PR apache/airflow#20833 tried to speed up the liveness probe by setting variable CONNECTION_CHECK_MAX_COUNT=0 which disables a connectivity check in `/entrypoint` (which turns out to be slow). Unfortunately the approach taken doesn't work; we have to use `sh -c exec` instead. GitOrigin-RevId: bca5caf3611fc8659b8bd5fdcddc04dc5b104344
kosteev
pushed a commit
to kosteev/composer-airflow-test-copybara
that referenced
this pull request
Sep 12, 2024
PR apache/airflow#20833 tried to speed up the liveness probe by setting variable CONNECTION_CHECK_MAX_COUNT=0 which disables a connectivity check in `/entrypoint` (which turns out to be slow). Unfortunately the approach taken doesn't work; we have to use `sh -c exec` instead. GitOrigin-RevId: bca5caf3611fc8659b8bd5fdcddc04dc5b104344
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 17, 2024
PR apache/airflow#20833 tried to speed up the liveness probe by setting variable CONNECTION_CHECK_MAX_COUNT=0 which disables a connectivity check in `/entrypoint` (which turns out to be slow). Unfortunately the approach taken doesn't work; we have to use `sh -c exec` instead. GitOrigin-RevId: bca5caf3611fc8659b8bd5fdcddc04dc5b104344
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 7, 2024
PR apache/airflow#20833 tried to speed up the liveness probe by setting variable CONNECTION_CHECK_MAX_COUNT=0 which disables a connectivity check in `/entrypoint` (which turns out to be slow). Unfortunately the approach taken doesn't work; we have to use `sh -c exec` instead. GitOrigin-RevId: bca5caf3611fc8659b8bd5fdcddc04dc5b104344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speedup liveness probe for scheduler and triggerer
Liveness probe is submitted through
/entrypointwhich by default runsairflow db check.This can be slow.
We can disable by setting
CONNECTION_CHECK_MAX_COUNT=0.