Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change import so hive_metastore is not a required module for operator tests #2079

Conversation

krishnabhupatiraju
Copy link
Contributor

Dear Airflow Maintainers,

Please accept this PR that addresses the following issues:

Testing Done:

  • Ran existing tests in tests/operators/. They were successful

@mention-bot
Copy link

@krishnabhupatiraju, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jlowin and @asnir to be potential reviewers.

@krishnabhupatiraju
Copy link
Contributor Author

@jlowin @artwr Could you take a look.

@jlowin
Copy link
Member

jlowin commented Feb 14, 2017

Thanks @krishnabhupatiraju -- I think that while your change will in fact prevent the file from being imported, it will also prevent it from being included in any unit tests. Let's see if Travis picks it up.

@jlowin
Copy link
Member

jlowin commented Feb 14, 2017

Also, I'm in love with this bot. @bolkedebruin is this your doing?

@gsakkis
Copy link
Contributor

gsakkis commented Feb 14, 2017

I think that while your change will in fact prevent the file from being imported, it will also prevent it from being included in any unit tests.

@jlowin please see #2078 that addressed this issue for many more dormant tests.

@codecov-io
Copy link

codecov-io commented Feb 14, 2017

Codecov Report

Merging #2079 into master will decrease coverage by -0.92%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2079      +/-   ##
==========================================
- Coverage   66.97%   66.05%   -0.92%     
==========================================
  Files         140      140              
  Lines       10639    10639              
==========================================
- Hits         7125     7028      -97     
- Misses       3514     3611      +97
Impacted Files Coverage Δ
airflow/operators/s3_to_hive_operator.py 0% <ø> (-94.18%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 485280a...a5c592b. Read the comment docs.

@krishnabhupatiraju
Copy link
Contributor Author

@jlowin #2078 does make the same change as this one. So closing this PR Off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants