Compare taskgroup and subdag #20700
Merged
Compare taskgroup and subdag #20700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Jan 6, 2022
|
LGTM but docs do not build |
|
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
kaxil
reviewed
Jan 6, 2022
There was a problem hiding this comment.
There are some spelling errors in the docs build:
Incorrect Spelling: 'Honours'
Incorrect Spelling: 'honour'
You could add this spelling to https://github.com/apache/airflow/blob/main/docs/spelling_wordlist.txt too if you think no spelling/word change is needed :)
eladkal
reviewed
Jan 6, 2022
potiuk
approved these changes
Jan 9, 2022
potiuk
pushed a commit
that referenced
this pull request
Jan 23, 2022
(cherry picked from commit 6b0c528)
jedcunningham
pushed a commit
that referenced
this pull request
Jan 27, 2022
(cherry picked from commit 6b0c528)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #12298
related: #12741
Pullling from the following resources:
I wrote a section to compare TaskGroup and SubDAGs with a tone that favours TaskGroups.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.