Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error when param value has unexpected type #20648

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

uranusjr
Copy link
Member

@uranusjr uranusjr commented Jan 4, 2022

I believe this is a much better solution than #20640. (A documentation addition is still not a bad idea with this change, but this makes the documentation easier to write.)

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jan 4, 2022
@uranusjr uranusjr force-pushed the better-param-error-message branch from 4a3db48 to bafc6b9 Compare January 4, 2022 09:48
@uranusjr uranusjr force-pushed the better-param-error-message branch from bafc6b9 to f4fd522 Compare January 4, 2022 09:50
@uranusjr uranusjr mentioned this pull request Jan 4, 2022
@uranusjr uranusjr merged commit a0cad07 into apache:main Jan 5, 2022
@uranusjr uranusjr deleted the better-param-error-message branch January 5, 2022 08:01
@jedcunningham jedcunningham added the type:improvement Changelog: Improvements label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:serialization full tests needed We need to run full set of tests for this PR to merge type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants