Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce deprecation warnings from www #20378

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Reduce deprecation warnings from www #20378

merged 1 commit into from
Dec 20, 2021

Conversation

uranusjr
Copy link
Member

Some things I found after disabling ignore::DeprecationWarning in #20322. Not all.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Dec 17, 2021
@uranusjr
Copy link
Member Author 

'airflow.models.dag.DagModel object' has no attribute 'get_is_paused'

Uh.

@uranusjr uranusjr marked this pull request as draft December 17, 2021 15:29
@ashb
Copy link
Member

ashb commented Dec 17, 2021 

'airflow.models.dag.DagModel object' has no attribute 'get_is_paused'

Uh.

DAG vs DagModel maybe?

@uranusjr uranusjr force-pushed the cleanup-www-deprecations branch from a68d2c0 to 1e53e44 Compare December 20, 2021 10:44
@uranusjr
Copy link
Member Author

Alright, working now. (The provider package build is failing due to #20420)

@uranusjr uranusjr marked this pull request as ready for review December 20, 2021 12:51
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 20, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@uranusjr uranusjr merged commit 9b05f02 into apache:main Dec 20, 2021
@uranusjr uranusjr deleted the cleanup-www-deprecations branch December 20, 2021 13:46
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbovenzi bbovenzi bbovenzi left review comments

@ashb ashb ashb left review comments

@kaxil kaxil kaxil approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@XD-DENG XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner

Assignees
No one assigned
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues full tests needed We need to run full set of tests for this PR to merge type:improvement Changelog: Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@uranusjr @ashb @bbovenzi @kaxil @ephraimbuddy