Rename TaskMixin to DependencyMixin #20297
Conversation
It was used on things that weren't tasks (such as XComArg and EdgeModifier) so the name was in-correct, and I want to disambiguate this from a concept I need to add for AIP-42 (Dynamic task mapping) of things that actually _are_ Tasks or Task-like objects. Since `Union[TaskMixin, Sequence[TaskMixin]]` was uses in so many places I created a type alias for this of `DependencyMixinOrList`
ashb
force-pushed
the
rename-taskmixin
branch
from
d4aac56 to
8374053
Compare
| # TODO: Deprecate for Airflow 3.0 | ||
| Chainable = Union[DependencyMixin, Sequence[DependencyMixin]] |
There was a problem hiding this comment.
Maybe it’s actually a good idea to keep using this name…? It’s unfortunately not super easy to deprecate a type alias.
There was a problem hiding this comment.
I don't think this alias is used anywhere beyond the usage a few lines below.
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
|
Also need to add |
Yeah, I didn't get that locally. I wonder why. (Also I wish sphinxcontrib-spelling was clever enough to ignore class and module names from the code base) |
I suspect it is for |
ephraimbuddy
added
the
type:misc/internal
It was used on things that weren't tasks (such as XComArg and
EdgeModifier) so the name was in-correct, and I want to disambiguate
this from a concept I need to add for AIP-42 (Dynamic task mapping) of
things that actually are Tasks or Task-like objects.
SinceUnion[TaskMixin, Sequence[TaskMixin]]was uses in so many placesI created a type alias for this of
DependencyMixinOrList^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.