Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimum sphinx versions after upgrading sphinx-autoapi #20170

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Update minimum sphinx versions after upgrading sphinx-autoapi #20170

merged 1 commit into from
Dec 10, 2021

Conversation

ashb
Copy link
Member

@ashb ashb commented Dec 9, 2021

  • Allow point releases of AutoAPI (I used with 1.8.4 in all my testing)

  • Require at least Sphinx v4

    A few things got deprecated in Sphinx 4, and as this dep is only for
    us building docs we can pick and choose what we like without impacting
    users, so lets stay up-to-date.

As noticed by @mik-laj in #20079 (comment)

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@ashb
Update minimum sphinx versions after upgrading sphinx-autoapi
0abf6b7 
* Allow point releases of AutoAPI (I used with 1.8.4 in all my testing)
* Require at least Sphinx v4

  A few things got deprecated in Sphinx 4, and as this dep is only for
  us building docs we can pick and choose what we like without impacting
  users, so lets stay up-to-date.
@ashb ashb requested a review from mik-laj December 9, 2021 15:31
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 9, 2021
@potiuk
Copy link
Member

potiuk commented Dec 9, 2021

However. I'd wait with merging it until constraints-main will refresh automatically with the new sphinx

@potiuk
Copy link
Member

potiuk commented Dec 9, 2021

They were on a good track to start refreshing quickly (after our tests stabilized) but stopped after the AWS docs publishing change - (@mik-laj promissed to fix it tonight): https://github.com/apache/airflow/runs/4472124262?check_suite_focus=true

potiuk
potiuk requested changes Dec 9, 2021
View reviewed changes
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in order to not accidentally merge it before constraint refresh

@ashb
Copy link
Member Author

ashb commented Dec 9, 2021

Oh IAM perms failing on main build for docs upload.

Error: User: arn:aws:sts:::assumed-role/ManualRunnerRole/i-0ecd356da541ffbc5 is not authorized to perform: sts:TagSession on resource: arn:aws:iam:::role/GithubActionApacheAirflow

Attempting to fix.

@ashb ashb closed this Dec 9, 2021
@ashb ashb reopened this Dec 9, 2021
@potiuk
Copy link
Member

potiuk commented Dec 9, 2021

Actually - the previously merged change #20079 would already trigger the conflict. So I upgraded the constraints manually and this one can be merged any time now d44aee8

@ashb ashb merged commit 214b62d into apache:main Dec 10, 2021
@ashb ashb deleted the correct-sphinx-min-version branch December 10, 2021 09:47
@potiuk potiuk added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 22, 2022
@potiuk potiuk added this to the Airflow 2.2.4 milestone Jan 22, 2022
potiuk pushed a commit that referenced this pull request Jan 22, 2022
@ashb @potiuk
Update minimum sphinx versions after upgrading sphinx-autoapi (#20170)
18ab3ed 
* Allow point releases of AutoAPI 1.8 (I used with 1.8.4 in all my testing)
* Require at least Sphinx v4

  A few things got deprecated in Sphinx 4, and as this dep is only for
  us building docs we can pick and choose what we like without impacting
  users, so lets stay up-to-date.

(cherry picked from commit 214b62d)
jedcunningham pushed a commit that referenced this pull request Jan 27, 2022
@ashb @jedcunningham
Update minimum sphinx versions after upgrading sphinx-autoapi (#20170)
d761aff 
* Allow point releases of AutoAPI 1.8 (I used with 1.8.4 in all my testing)
* Require at least Sphinx v4

  A few things got deprecated in Sphinx 4, and as this dep is only for
  us building docs we can pick and choose what we like without impacting
  users, so lets stay up-to-date.

(cherry picked from commit 214b62d)
@potiuk potiuk mentioned this pull request Jun 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mik-laj mik-laj mik-laj approved these changes

@potiuk potiuk potiuk approved these changes

Assignees
No one assigned
Labels
changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Milestone
Airflow 2.2.4
Development

Successfully merging this pull request may close these issues.
3 participants
@ashb @potiuk @mik-laj