Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Qubole how to documentation #20058

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Add Qubole how to documentation #20058

merged 1 commit into from
Dec 6, 2021

Conversation

kazanzhy
Copy link
Contributor

@kazanzhy kazanzhy commented Dec 5, 2021

Add draft of Qubole how-to documentation for Qubole Operators and Sensors
I will be very glad to any suggestions, especially from Qubole users.

closes: #10929

@kazanzhy kazanzhy mentioned this pull request Dec 5, 2021
Closed
@potiuk
Copy link
Member

potiuk commented Dec 5, 2021

Nice @chattarajoy waiting for your review to merge :)

@kazanzhy kazanzhy force-pushed the fix_issue_10929 branch 2 times, most recently from a1cb37f to 171146e Compare December 6, 2021 11:44
chattarajoy
chattarajoy approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@chattarajoy chattarajoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kazanzhy
Copy link
Contributor Author

kazanzhy commented Dec 6, 2021

Just fixed some issues with doc build.
Now local doc building works well

@potiuk
Copy link
Member

potiuk commented Dec 6, 2021

some provider.yaml inconsistency :)

@potiuk
Copy link
Member

potiuk commented Dec 6, 2021 •
edited
Loading

BTW @kazanzhy. I STRONGLY recommend pip install pre-commit followed by pre-commit install. It saves a TON of time on iterations like that :).
See https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#id3

@kazanzhy
Copy link
Contributor Author

kazanzhy commented Dec 6, 2021

Did it, thanks
Just trying to figure out what's wrong

@kazanzhy kazanzhy changed the title Draft: Add Qubole how to documentation Add Qubole how to documentation Dec 6, 2021
@potiuk
Copy link
Member

potiuk commented Dec 6, 2021

Hey @kazanzhy - small comment :). Could you please use Github's "Draft" feature instaead of adding Draft: in the subject?

https://github.blog/2019-02-14-introducing-draft-pull-requests/

The side effect of changing the subject is that if you are subscribed to GitHub notifications via email, the thread gets split.

@potiuk potiuk merged commit 2fbfbef into apache:main Dec 6, 2021
@kazanzhy
Copy link
Contributor Author

kazanzhy commented Dec 6, 2021

Copy that. Sorry for the bad habit from Gitlab :)

@kazanzhy kazanzhy deleted the fix_issue_10929 branch December 6, 2021 21:15
This was referenced Feb 5, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chattarajoy chattarajoy chattarajoy approved these changes

@potiuk potiuk potiuk approved these changes

@mik-laj mik-laj Awaiting requested review from mik-laj

@vikramkoka vikramkoka Awaiting requested review from vikramkoka

Assignees
No one assigned
Labels
area:providers kind:documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add how to documentation for Qubole Operator
3 participants
@kazanzhy @potiuk @chattarajoy