-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove get_readable_dag, get_editable_dag, and get_accessible_dags. #19961
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI still seems to work but I can't comment on the code itself.
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why though?
It seems expensive to have to get full DAGModel objects just to then throw away all that info and keep the dag_ids only.
How many places do we actually use get_readable_dags
etc and want the dags vs the IDs?
Would it perhaps make more sense to replace get_accessible_dags
with a get_accesible_dag_ids
that directly returns the IDs?
a9a590f
to
f8ab965
Compare
@ashb good call. That was actually a simpler change overall, which I've made. |
As part of cleaning up FAB, we're minimizing the size of the interface by removing unnecessary helper methods. This PR removes
get_readable_dags
,get_editable_dags
, andget_accessible_dags
.