Add clear logging to tasks killed due to a Dagrun timeout #19950
+49
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
SamWheating
force-pushed
the
sw-log-dagrun-timeouts
branch
from
d7adcf3 to
c124c53
Compare
ephraimbuddy
reviewed
Dec 2, 2021
SamWheating
force-pushed
the
sw-log-dagrun-timeouts
branch
2 times, most recently
from
6c58260 to
ef9090a
Compare
ephraimbuddy
reviewed
Dec 7, 2021
|
cc: @ashb |
SamWheating
force-pushed
the
sw-log-dagrun-timeouts
branch
from
ef9090a to
d3be32a
Compare
SamWheating
commented
Dec 9, 2021
kaxil
reviewed
Dec 9, 2021
Co-authored-by: Kaxil Naik <[email protected]>
kaxil
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a DagRun exceeds its
dagrun_timeoutvalue a few things happen:failedskipped(which causes running tasks to be SIGTERM'd)INFO: Run $RUN_NUMBER of $DAG_ID has timed-outThis has caused some confusion amongst users as its hard to tell why running tasks were killed without either:
dagrun_timeoutvalue with the execution timeThis PR adds additional messaging into the task logs when it can be inferred that the task was killed due to a DagRun timeout.
I'm not super happy with this implementation (as it kind of duplicates the timeout logic to infer that a timeout occurred) and would really appreciate some advice on other ways we can improve the clarity around timeouts.
I'll add some tests for this once I get some feedback on the initial approach.