Re-enables MyPy in non-failure mode #19890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
uranusjr,
dstandish,
BasPH,
turbaszek,
jedcunningham and
kaxil
ashb
reviewed
Nov 30, 2021
ashb
reviewed
Nov 30, 2021
ashb
reviewed
Nov 30, 2021
potiuk
force-pushed
the
enable-mypy-as-non-failing-step
branch
from
8579b89 to
3092db0
Compare
|
I also did not commit some workflow modifications from a bigger commit - this one should be much better. |
potiuk
force-pushed
the
enable-mypy-as-non-failing-step
branch
2 times, most recently
from
4ea0b67 to
09df063
Compare
This PR enables mypy back as pre-commit for local changes after the apache#19317 switched to Python 3.7 but also it separates out mypy to a separate non-failing step in CI. In the CI we will be able to see remaining mypy errors. This will allow us to gradually fix all the mypy errors and enable mypy back when we got all the problems fixed.
potiuk
force-pushed
the
enable-mypy-as-non-failing-step
branch
from
09df063 to
6b33abf
Compare
|
I think this one should be ready to merge, we need to merge it to start working on #19891 |
|
Looks GOOD. |
mik-laj
approved these changes
Nov 30, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
jedcunningham
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables mypy back as pre-commit for local changes after
the #19317 switched to Python 3.7 but also it separates out
mypy to a separate non-failing step in CI.
In the CI we will be able to see remaining mypy errors.
This will allow us to gradually fix all the mypy errors and enable
mypy back when we got all the problems fixed.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.