-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api add support bulk pause resume #19758
Api add support bulk pause resume #19758
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
c5255de
to
bff0351
Compare
41e52de
to
a300098
Compare
730ce99
to
f5d042d
Compare
2e88ce4
to
d95b6a3
Compare
d95b6a3
to
6dea9f2
Compare
@ephraimbuddy could you please review again? |
6dea9f2
to
d0060d3
Compare
d0060d3
to
7c512f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks good. Yea, the dag_id_pattern is required on the patch endpoint
but not required on get endpoint
. I suggest to only work on the patch endpoint
in this PR and work on the get endpoint
in a separate PR.
7c512f2
to
bc8d9ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
One more ask, add a test to validate that the dag_id_pattern is required for this endpoint to avoid someone removing it in the future
9025937
to
2ee1ee9
Compare
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Awesome work, congrats on your first merged pull request! |
Endpoint for Bulk Updates to DAGs
Currently the Airflow REST API only allows us to pause/resume (update) one DAG per request. We often need to pause/resume DAGs in bulk. To avoid maintaining a separate set of custom endpoints that will be fragile, it makes sense to update the
patch_dag
endpoint to handle bulk requests.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.