-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DAG run details page #19705
Add DAG run details page #19705
Conversation
{% for attribute, value in dagrun_attributes %} | ||
<tr> | ||
<td class="text-nowrap">{{ attribute }}</td> | ||
<td>{{ value }}</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm that the dates here update when you change the app's timezone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I believe we'd want all of them to update. I think we have another spot where we check if an attribute value is a date and wrap it in a <timezone>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Question about this - Thanks! |
It sounds like you're looking for an overview of multiple DAG runs. I'd say the DAG runs list (Browse -> DAG Runs) and/or the new tree view in Airflow 2.3 should provide that information. Anything in specific that you're currently missing? The view added in this PR is meant for showing details of one single DAG run (my main reason for adding it was to inspect the DAG run conf). |
Ah sorry @BasPH think I got confused when linked here. Yeah essentially the case is that for many users in our experience, asking them to navigate to the dag run list and fill in the filters is too much work. They want at the same view as the graph/tree/code/etc. to have a view to see the dag runs to quickly at a glance figure out outliers, and other information. Internally we have provided this and originally was told this was desired by greater community, but I think there are some reservations now, so want to know is there any plan to provide a quick view of this with some of the ongoing work or is it still going to be recommended to go to this other view to do the search for it. |
Has this button been removed in most recent versions? I can't seem to find it in the UI in v2.6.3 |
All of those buttons are available in the grid view when you select a dag run via clicking on the bar chart. |
This PR adds a DAG run details page showing information about one single DAG run.
I have a couple of DAGs where every run is triggered with parameters and found it difficult to trace which parameters were used to trigger a DAG in the Airflow UI. The current flow is:
This PR adds a new button to the modal clicking on a DAG run bar in the tree view:
That brings you to the DAG run details page: