Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DAG run details page #19705

Merged
merged 3 commits into from
Nov 22, 2021
Merged

Add DAG run details page #19705

merged 3 commits into from
Nov 22, 2021

Conversation

BasPH
Copy link
Contributor

@BasPH BasPH commented Nov 19, 2021

This PR adds a DAG run details page showing information about one single DAG run.

I have a couple of DAGs where every run is triggered with parameters and found it difficult to trace which parameters were used to trigger a DAG in the Airflow UI. The current flow is:

  1. Hover over DAG run in tree view
  2. Memorize a property to identify specific DAG run, usually the run id (memorize because toolbox disappears when cursor leaves the DAG run circle)
  3. Go to Browse -> DAG runs
  4. Filter using property from step 2

This PR adds a new button to the modal clicking on a DAG run bar in the tree view:
image

That brings you to the DAG run details page:
image

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Nov 19, 2021
{% for attribute, value in dagrun_attributes %}
<tr>
<td class="text-nowrap">{{ attribute }}</td>
<td>{{ value }}</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that the dates here update when you change the app's timezone?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently only this date updates:
image

The other dates include timezone offsets, shall I make them all update when changing the timezone?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe we'd want all of them to update. I think we have another spot where we check if an attribute value is a date and wrap it in a <timezone>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. By default, the milliseconds are not displayed so it now looks like:
image

Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Nov 19, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@bbovenzi bbovenzi merged commit 968952b into apache:main Nov 22, 2021
@BasPH BasPH deleted the add-dag-run-details-page branch November 22, 2021 19:34
@Acehaidrey
Copy link
Contributor

Question about this -
Will there be a simple way for the user to see the list of dagruns and their runtime / duration / state information. To me here, it still feels like we will need to click around to be able to see this and change from view to view.
Just want to know since there were two PRs today (one being from me) regarding this issue.

Thanks!

@BasPH
Copy link
Contributor Author

BasPH commented Dec 1, 2021

It sounds like you're looking for an overview of multiple DAG runs. I'd say the DAG runs list (Browse -> DAG Runs) and/or the new tree view in Airflow 2.3 should provide that information. Anything in specific that you're currently missing? The view added in this PR is meant for showing details of one single DAG run (my main reason for adding it was to inspect the DAG run conf).

@Acehaidrey
Copy link
Contributor

Ah sorry @BasPH think I got confused when linked here. Yeah essentially the case is that for many users in our experience, asking them to navigate to the dag run list and fill in the filters is too much work. They want at the same view as the graph/tree/code/etc. to have a view to see the dag runs to quickly at a glance figure out outliers, and other information. Internally we have provided this and originally was told this was desired by greater community, but I think there are some reservations now, so want to know is there any plan to provide a quick view of this with some of the ongoing work or is it still going to be recommended to go to this other view to do the search for it.
It's in regards to this: #19921

@ephraimbuddy ephraimbuddy added the type:new-feature Changelog: New Features label Apr 14, 2022
@pilijevski
Copy link

Has this button been removed in most recent versions? I can't seem to find it in the UI in v2.6.3

@bbovenzi
Copy link
Contributor

Has this button been removed in most recent versions? I can't seem to find it in the UI in v2.6.3

All of those buttons are available in the grid view when you select a dag run via clicking on the bar chart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants