-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use built-in check-migrations command for Airflow>=2 in helm chart #19676
Use built-in check-migrations command for Airflow>=2 in helm chart #19676
Conversation
Well some of the Helm chart tests passed, that's promising. |
Curious. I wonder why only some of the helm chart matrix failed with that. |
Oh !!! 🤦 We deleted that DAG and added everything |
Need: diff --git a/kubernetes_tests/test_kubernetes_executor.py b/kubernetes_tests/test_kubernetes_executor.py
index 1ca3848fe..61030d1b9 100644
--- a/kubernetes_tests/test_kubernetes_executor.py
+++ b/kubernetes_tests/test_kubernetes_executor.py
@@ -25,7 +25,7 @@ from kubernetes_tests.test_base import EXECUTOR, TestBase
@pytest.mark.skipif(EXECUTOR != 'KubernetesExecutor', reason="Only runs on KubernetesExecutor")
class TestKubernetesExecutor(TestBase):
def test_integration_run_dag(self):
- dag_id = 'example_kubernetes_executor_config'
+ dag_id = 'example_kubernetes_executor'
dag_run_id, execution_date = self.start_job_in_kubernetes(dag_id, self.host)
print(f"Found the job with execution_date {execution_date}")
@@ -48,7 +48,7 @@ class TestKubernetesExecutor(TestBase):
)
def test_integration_run_dag_with_scheduler_failure(self):
- dag_id = 'example_kubernetes_executor_config'
+ dag_id = 'example_kubernetes_executor'
dag_run_id, execution_date = self.start_job_in_kubernetes(dag_id, self.host) But we can create a separate PR for that |
Turns out living with broken tests is bad -- who'da thunk it!? |
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Nice!. Just got back to my PC :) |
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.