Fix MySQL db migration with default encoding/collation #19268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Oct 28, 2021
airflow/migrations/versions/7b2661a43ba3_taskinstance_keyed_to_dagrun.py
Show resolved
Hide resolved
A check in |
kaxil
approved these changes
Oct 28, 2021
Yup, a separate PR though |
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
|
Agree. Checking it (incliding providing instructions on how to fix it) before migration is a very good idea (and agree with @kaxil it should be separate PR). |
|
Jeez. I hate MySQL. |
potiuk
approved these changes
Oct 28, 2021
jedcunningham
force-pushed
the
mysql_migrations
branch
from
efe2626 to
edff7c1
Compare
jedcunningham
force-pushed
the
mysql_migrations
branch
from
edff7c1 to
c91ce46
Compare
2 tasks
jedcunningham
added a commit
that referenced
this pull request
Nov 3, 2021
(cherry picked from commit e76a69b)
This was referenced Nov 10, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the migrations to complete for MySQL db's without proper encoding/collation defaults.
I almost feel that we should be blocking migrations from running if they aren't set properly? Thoughts?
Related: #18939