Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialization of Params with set data type #19267

Merged
merged 15 commits into from
Nov 5, 2021
Merged

Fix serialization of Params with set data type #19267

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
aa16e01
Fix serialization of Params with set data type
dstandish Oct 27, 2021
2830cca
restore backward compat
dstandish Oct 28, 2021
97fddf2
add test case for when params are sets
dstandish Oct 28, 2021
f98768f
serialization should cover all attrs besides __class
dstandish Oct 28, 2021
0fc6c0e
handle params serialized in 2.2.0, when param attrs were not run thro…
dstandish Oct 29, 2021
33ac787
be more explicit about ser and deser; add tests
dstandish Oct 29, 2021
fc7f4f5
update param schema
dstandish Oct 29, 2021
6fa83fd
add comment
dstandish Oct 29, 2021
01eacb4
update schema: dag
dstandish Nov 3, 2021
ec839e4
fix schema
dstandish Nov 4, 2021
10b1458
validate json serializable in param init
dstandish Nov 4, 2021
a9b56ef
update schema to reflect old params structure
dstandish Nov 4, 2021
d4cc825
don't validate pre-2.2.0 schema against current schema
dstandish Nov 4, 2021
838f2df
fix path
dstandish Nov 5, 2021
b097396
revert json validation
dstandish Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion airflow/serialization/serialized_objects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,10 @@ def _serialize_param(cls, param: Param):
@classmethod
def _deserialize_param(cls, param_dict: Dict):
param_class = import_string(param_dict.pop(Param.CLASS_IDENTIFIER))
param_kwargs = cls._deserialize(param_dict)
try:
param_kwargs = cls._deserialize(param_dict)
except KeyError:
param_kwargs = param_dict
dstandish marked this conversation as resolved.
Show resolved Hide resolved
return param_class(**param_kwargs)

@classmethod
Expand Down