-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Minor] Fix padding on home page #19025
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
CI failed for "Quarantined tests" looks unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table intentionally does not have extra padding given its extra-wide contents. The actual issue here is that the pagination buttons and "Showing 1-2…" label aren't supposed to be within the gray box, they are supposed to be below/outside of it. Their current positions actually appear correct, they just shouldn't have the gray background. Want to take a stab at resolving?
@ryanahamilton Sure, which one looks better? |
I think option-2 is more consistent. I would just make sure that any dropdowns and tooltips don't get cut off. |
Could you also check all hover/dropdowns on the last row of a table? |
- col span should be 10 instead of 9
@bbovenzi I see, there are a lot of things happening in there. Sorry, about not being careful. Let me try this on a couple of different browsers with different resolutions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now. Great work!
Thank you @bbovenzi for mentoring me on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small nit regarding class naming, but otherwise LGTM.
@@ -141,7 +141,7 @@ <h2>{{ page_title }}</h2> | |||
</thead> | |||
<tbody> | |||
{% if dags|length == 0 %} | |||
<tr><td colspan="9">No results</td></tr> | |||
<tr><td colspan="10">No results</td></tr> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Co-authored-by: Ryan Hamilton <[email protected]>
dd2574b
to
0babe2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Always fun how these seemingly simple changes open a whole can of worms!
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Yes, agreed :) |
Awesome work, congrats on your first merged pull request! |
* [Minor] fix padding on home page * fix lint * Move filters and pagination out from dags-table-wrap * - fix last row of a table - col span should be 10 instead of 9 * add bottom padding * Update airflow/www/static/css/dags.css Co-authored-by: Ryan Hamilton <[email protected]> Co-authored-by: Ryan Hamilton <[email protected]>
This is a minor CSS to add padding on the table and paginator. It does not make or break anything but makes this page looks slightly different from others.
I've added before/after below for reviewers.
Let me know if this requires any more changes.
Before:
After: