Convert www.security test suite to pytest and remove residuals #18961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khalidmammadov
force-pushed
the
convert_unittest_to_pytest_test_sec
branch
from
4cea41f to
8ddc513
Compare
uranusjr
requested changes
Oct 18, 2021
uranusjr
approved these changes
Oct 19, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
khalidmammadov
force-pushed
the
convert_unittest_to_pytest_test_sec
branch
from
a996ceb to
16191ca
Compare
khalidmammadov
force-pushed
the
convert_unittest_to_pytest_test_sec
branch
2 times, most recently
from
d41ea68 to
bed5597
Compare
uranusjr
reviewed
Nov 11, 2021
khalidmammadov
force-pushed
the
convert_unittest_to_pytest_test_sec
branch
from
bed5597 to
9a0297d
Compare
uranusjr
approved these changes
Nov 15, 2021
potiuk
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
LGTM. @khalidmammadov how about rebasing that one to re-check the tests?
khalidmammadov
force-pushed
the
convert_unittest_to_pytest_test_sec
branch
from
41e1014 to
5324297
Compare
Co-authored-by: Tzu-ping Chung <[email protected]>
khalidmammadov
force-pushed
the
convert_unittest_to_pytest_test_sec
branch
from
5324297 to
31550c5
Compare
|
@potiuk re-based and all looks ok to me except failures which are not related and can be seen other PRs as well. ( Actually, I took a look at them as well but couldn't reproduce..) Anything else to do here? |
dillonjohnson
pushed a commit
to dillonjohnson/airflow
that referenced
this pull request
Dec 1, 2021
…e#18961) Co-authored-by: Tzu-ping Chung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses number of issues:
I tried to keep tests as they are and only fixed unittest specific/dependent parts and did some corrections or optimizations when I saw necessary.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.