-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add decription on how you can customize image entrypoint #18915
Conversation
I still believe there is an use case for executing stuff BEFORE the entrypoint. In our case, we override the DB pointer dynamically, depending on some values in the ENV -> can only be set at runtime. Hence must run before the entrypoint as the latter ( Our way around it: build an image with our |
Good point. I added this option to the PR with documentation : #18915 There are a few things that you have to be aware of (read the docs) in this case:
I explained that all in the PR #18915 |
I also added code explaining that "before" executing Airflow's entrypoint, certain functionality is not be available (updated the PR)
|
a03147e
to
9b30b90
Compare
Cool. Now I need just an approve from another committer :). Anyone? |
6ee760b
to
46519ef
Compare
46519ef
to
bb4fd13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, it makes sense as it is written now 👍
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
1 similar comment
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Co-authored-by: Jed Cunningham <[email protected]>
Co-authored-by: Jed Cunningham <[email protected]>
Co-authored-by: Jed Cunningham <[email protected]>
Co-authored-by: Jed Cunningham <[email protected]>
Co-authored-by: Jed Cunningham <[email protected]>
Co-authored-by: Jed Cunningham <[email protected]>
(cherry picked from commit cc627b3)
(cherry picked from commit cc627b3)
(cherry picked from commit cc627b3)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.