Fix comparision of docker versions #18902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some shells the comparable string with version was too long. The number leading with 0 was interpreted as octal number and it had too many digits for octal number to handle. This change; 1) decreases the length of the string by using 3-digit numbers 2) strips leading 0s during comparision making comparision work in decimal
mik-laj
reviewed
Oct 12, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
potiuk
added a commit
that referenced
this pull request
Jan 22, 2022
In some shells the comparable string with version was too long. The number leading with 0 was interpreted as octal number and it had too many digits for octal number to handle. This change; 1) decreases the length of the string by using 3-digit numbers 2) strips leading 0s during comparision making comparision work in decimal (cherry picked from commit a05f0c3)
potiuk
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some shells the comparable string with version was too long.
The number leading with 0 was interpreted as octal number and
it had too many digits for octal number to handle.
This change;
in decimal
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.